Skip to content

Commit

Permalink
fix(docker): make healthcheck work when proxy is set
Browse files Browse the repository at this point in the history
In docker setups that use a proxy for internet access, exclude the
wget healthcheck from using the proxy when connecting to localhost.

Fix from Norbert Schlemmer.
  • Loading branch information
Norbert Schlemmer Noschvie on github.com committed Oct 25, 2023
1 parent 9ffa1d0 commit ce2b540
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ Fixed:
- use unittest.mock rather than mock for
test/test_hyperdbvals.py. (found by Ralf Schlatterbeck. Fix John
Rouillard)
- disable proxy with wget in roundup_healthcheck. (Norbert SCHLEMMER
Noschvie on github.com)

Features:

Expand Down
2 changes: 1 addition & 1 deletion scripts/Docker/roundup_healthcheck
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# returns last one for testing that server is up. Does not test
# each tracker.
tracker=$(ps -ef | sed -ne '/roundup-server/s/^.*\s\(\w*\)=.*$/\1/p')
wget -q -O /dev/null --no-verbose http://localhost:8080/"${tracker:-demo}"/
wget -q -O /dev/null --proxy off --no-verbose http://localhost:8080/"${tracker:-demo}"/

0 comments on commit ce2b540

Please sign in to comment.