Skip to content

Commit

Permalink
cleanup special case - xapian doesn't build in CI for 3.13 python
Browse files Browse the repository at this point in the history
Remove python version checks from xapian script. Keep if: clause that
skips xapian install on 3.13 until we are on ubuntu-24.04 image.

python xapian binding for 1.4.22 looks like it builds correctly on 24.04.

https://github.com/roundup-tracker/roundup/actions/runs/11784123806/job/32822658400

[skip travis]
  • Loading branch information
rouilj committed Nov 11, 2024
1 parent 1d5c9f3 commit 28a7dc3
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@ jobs:
pip install Markdown; fi
- name: Install xapian
# comment the if: line out once we start running on
# ubuntu-24.04. 24.04 has xapian 1.4.22 which builds
# correctly with python 3.13.
if: matrix.python-version != '3.13'
run: |
set -xv
Expand All @@ -264,11 +267,7 @@ jobs:
# older python and newest on newer.
if [[ $PYTHON_VERSION == "2."* ]]; then pip install sphinx==1.8.5; fi
if [[ $PYTHON_VERSION == '3.'* ]] ; then pip install sphinx; fi
if [[ $PYTHON_VERSION != "3.13" ]]; then
XAPIAN_VER=$(dpkg -l libxapian-dev | tail -n 1 | awk '{print $3}' | cut -d '-' -f 1); echo $XAPIAN_VER;
else
XAPIAN_VER="1.4.25"; echo $XAPIAN_VER;
fi
XAPIAN_VER=$(dpkg -l libxapian-dev | tail -n 1 | awk '{print $3}' | cut -d '-' -f 1); echo $XAPIAN_VER;
cd /tmp
curl -s -O https://oligarchy.co.uk/xapian/$XAPIAN_VER/xapian-bindings-$XAPIAN_VER.tar.xz
tar -Jxvf xapian-bindings-$XAPIAN_VER.tar.xz
Expand All @@ -291,7 +290,7 @@ jobs:
diff -u configure.FCS configure || true; \
./configure --prefix=$VIRTUAL_ENV --with-python3 --disable-documentation; \
fi
case "$PYTHON_VERSION" in "3.13") echo skipping xapian build;; *) make && sudo make install; esac
make && sudo make install
- name: Test build roundup and install locale so lang tests work.
run: |
Expand Down

0 comments on commit 28a7dc3

Please sign in to comment.