Fix compatibility for php 5.3

rougin · Nov 26, 2023 · e439b28 · e439b28
1 parent 1adbc80
commit e439b28
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -33,27 +33,31 @@ jobs:
     - name: Install dependencies
       run: composer install --prefer-dist --no-progress
 
-    - name: Install Composer packages not for PHP 5.3
+    - name: Install third-party packages for PHP 5.3
+      if: ${{ matrix.php-versions == '5.3' }}
+      run: composer require http-interop/http-middleware:^0.4.1 twig/twig:~1.4 --dev
+
+    - name: Install third-party packages not for PHP 5.3
       if: ${{ matrix.php-versions != '5.3' }}
       run: composer require filp/whoops nikic/fast-route phroute/phroute rdlowrey/auryn zendframework/zend-diactoros http-interop/http-middleware:^0.4.1 league/container:~2.4 twig/twig:~1.4 --dev
 
-    - name: Install Composer packages for PHP 7.1
+    - name: Install third-party packages for PHP 7.1
       if: ${{ matrix.php-versions == '7.1' }}
       run: composer require zendframework/zend-stratigility:~2.0 --dev
 
-    - name: Install Composer packages for PHP 7.2
+    - name: Install third-party packages for PHP 7.2
       if: ${{ matrix.php-versions == '7.2' }}
       run: composer require zendframework/zend-stratigility:~2.0 --dev
 
-    - name: Install Composer packages for PHP 7.3
+    - name: Install third-party packages for PHP 7.3
       if: ${{ matrix.php-versions == '7.3' }}
       run: composer require zendframework/zend-stratigility:~2.0 --dev
 
-    - name: Install Composer packages for PHP 7.4
+    - name: Install third-party packages for PHP 7.4
       if: ${{ matrix.php-versions == '7.4' }}
       run: composer require zendframework/zend-stratigility:~2.0 --dev
 
-    - name: Install Composer packages for PHP 8.1
+    - name: Install third-party packages for PHP 8.1
       if: ${{ matrix.php-versions == '8.1' }}
       run: composer require twig/twig --dev
 

diff --git a/tests/Sample/Router.php b/tests/Sample/Router.php
@@ -33,7 +33,7 @@ public function routes($parsed = false)
 
         $this->get('/param', 'Home@param');
 
-        $this->get('/handler/const', 'Hello@const');
+        $this->get('/handler/conts', 'Hello@conts');
 
         $this->get('/handler/param', 'Hello@param');
 

diff --git a/tests/Sample/Routes/Hello.php b/tests/Sample/Routes/Hello.php
@@ -11,7 +11,7 @@
  */
 class Hello extends Route
 {
-    public function const()
+    public function conts()
     {
         $data = $this->request->getParsedBody();
 

diff --git a/tests/Sample/SampleTest.php b/tests/Sample/SampleTest.php
@@ -129,7 +129,7 @@ public function test_with_middleware_changing_the_request_constructor()
     {
         $this->builder->addHandler(new Parsed);
 
-        $this->builder->setUrl('GET', '/handler/const');
+        $this->builder->setUrl('GET', '/handler/conts');
 
         $this->expectOutputString('Hello, Slytherin!');