Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download window is showing up when the webPreferences.partition option. #9

Open
overflowz opened this issue Dec 6, 2016 · 5 comments

Comments

@overflowz
Copy link

Title says it all. Whenever I try to set the webPreferences.partition option to random string (without "persist:" prefix) and trying to download a file, it shows download dialog instead and waits for interaction. any thoughts?

@rosshinkley
Copy link
Owner

Sorry for the protracted delay in responding: I think this is probably an issue with how the download path is being set. I'll dig into this and see what comes out.

@rosshinkley
Copy link
Owner

Based on what you provided here, the download link is opening a temporary window. Nightmare does not support multiple windows out of the box just yet (see segment-boneyard/nightmare#593).

Multiwindow support has been on my backburner, but this may be the impetus to get started in earnest. Working with downloads will give me an ample problem space to explore the problems that are baked into multitab/window support.

@overflowz
Copy link
Author

but why it works when I specify partition to null? (persistent)

@rosshinkley
Copy link
Owner

Can you provide a minimal example? When I try to set the partition to null, the Nightmare IPC crashes.

@overflowz
Copy link
Author

I provided already here: segment-boneyard/nightmare#928 (comment) (just add partition: null in webPreferences).
as for crash, it's weird. it never happened to me though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants