Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-extra dependency causes problems #17

Open
yoz opened this issue Mar 21, 2017 · 0 comments
Open

fs-extra dependency causes problems #17

yoz opened this issue Mar 21, 2017 · 0 comments

Comments

@yoz
Copy link

yoz commented Mar 21, 2017

Because it's used inside a Nightmare action, fs-extra has to be resolvable from within nightmare, which means in npm 2 it gets very messy. The following is ok:

parent-package
- child-package
  - nightmare
  - nightmare-download-manager
  - fs-extra

This is not ok and results in MODULE_NOT_FOUND:

parent-package
- nightmare
- child-package
  - nightmare-download-manager
  - fs-extra

Yet this is ok:

parent-package
- nightmare
- fs-extra
- child-package
  - nightmare-download-manager

I'm not sure where things stand with npm v3 but I don't think devDependencies is the correct place for fs-extra in any case.

I'm honestly unsure where this should be fixed (in nightmare?) but it seems like the simplest workaround is to not use fs-extra inside of an action.

(Can we use fs-extra move() into the destination directory in the parent process rather than the child runner?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant