Skip to content

Commit

Permalink
[messaging] Security fix: do not allow random message deletion.
Browse files Browse the repository at this point in the history
  • Loading branch information
alexef committed Sep 27, 2013
1 parent 7e4950d commit d137a56
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions wouso/interface/apps/messaging/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ def create(request, to=None, reply_to=None):
@login_required
def message(request, mid):
message = get_object_or_404(Message, pk=mid)

me = request.user.get_profile().get_extension(MessagingUser)

if message.sender == me or message.receiver == me:
Expand All @@ -88,10 +87,16 @@ def message(request, mid):
context_instance=RequestContext(request))
raise Http404


@login_required
def delete(request, id):
message = get_object_or_404(Message, pk=id)
message.delete()
me = request.user.get_profile().get_extension(MessagingUser)

if message.sender == me or message.receiver == me:
message.delete()
else:
raise Http404
go_back = request.META.get('HTTP_REFERER', None)
if not go_back:
go_back = reverse('wouso.interface.messaging.views.home')
Expand Down

0 comments on commit d137a56

Please sign in to comment.