Cast pathlib.Path to str inside normalize_to_list_of_substitutions. #806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #805. More details can be found there.
After backporting the commit to
humble
, I have tested it to at least work on my launch files, allowing me to remove thestr()
cast.Since this is my first time, I am not exactly sure how to run tests, but I think this means its good?
EDIT:
Also would it be possible to backport this to humble? Thanks