Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix expectation for test on Windows #319

Merged
merged 1 commit into from
Aug 24, 2019
Merged

fix expectation for test on Windows #319

merged 1 commit into from
Aug 24, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Aug 24, 2019

Follow up for #277 to fix CI until we can re-enable this feature.

CI (up to launch):

before (windows):

  • Build Status

after:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
fix expectation for test on Windows
8d291ee 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Aug 24, 2019
@wjwwood wjwwood requested a review from cottsay August 24, 2019 00:35
@wjwwood wjwwood self-assigned this Aug 24, 2019
@wjwwood
Copy link
Member Author

wjwwood commented Aug 24, 2019

@cottsay I think this will address the Windows failure on nightly until #286 is completed.

cottsay
cottsay approved these changes Aug 24, 2019
View reviewed changes
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as #286 can track the follow-up solution.

@cottsay cottsay merged commit b1bc1f5 into master Aug 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_emulate_tty_test_on_windows branch August 24, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@wjwwood wjwwood

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjwwood @cottsay