Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for clippy 1.83 #441

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Update for clippy 1.83 #441

merged 4 commits into from
Dec 2, 2024

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented Dec 2, 2024

Stable CI for new PRs are failing right now because of an update in clippy 1.83 that emits a warning when an explicit lifetime can be elided.

This PR updates based on the clippy recommendation, so Stable CI should go green now.

Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and simple fix. Thank you!

@jhdcs jhdcs merged commit 3eba2b0 into ros2-rust:main Dec 2, 2024
6 checks passed
@mxgrey mxgrey deleted the fix_clippy_stable branch December 2, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants