Fix GHA status labels #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jballoffet
force-pushed
the
jballoffet/fix-gha-labels
branch
from
7215599 to
c096e52
Compare
mxgrey
suggested changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks for catching this. This should've been updated in #420 but I overlooked the readme links.
I just have two recommendations for the links, which I've given suggested changes for below:
- Filter the branch for the badge that we display on the README so it's only for the main branch. Without this every PR whose CI fails will turn the badge red.
- Give a slightly more meaningful name for the fallback text.
|
Be sure to merge the latest |
jballoffet
force-pushed
the
jballoffet/fix-gha-labels
branch
from
c096e52 to
d1ad101
Compare
Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
jballoffet
force-pushed
the
jballoffet/fix-gha-labels
branch
from
d1ad101 to
17f79c1
Compare
Thank you @mxgrey for the review! All comments addressed and branch rebased, CI shall pass now. |
jhdcs
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the GitHub Action label after the corresponding workflows were renamed on #429..
Change involved
This PR applies the following changes:
rust-minimal.yamlandrust-stable.yaml).ubuntu-latestis used for CI jobs).How was this tested?
Rendered README file visually inspected.