Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rviz crash if launch later (backport #4882) #4883

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4754
Primary OS tested on Ubuntu 24.04
Robotic platform tested on turtlebot 3 simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Revival of #4871 targeting the main branch with improved code

  • Open a new thread to load plugins, to ensure that get_parameter() would not block the main thread. The combo box will now have value if it successfully gets the parameter, otherwise empty

Description of documentation updates required from your changes

None

Description of how this change was tested

Extensively tested on tb3 simulation and all tests passed


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
    This is an automatic backport of pull request Fix rviz crash if launch later #4882 done by Mergify.

* Fix rviz crash if start later

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Bring back default rviz launch file

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* New line

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Whitespace

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add log when failed

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 4192372)
Copy link
Contributor Author

mergify bot commented Jan 29, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 861ee25 into jazzy Jan 29, 2025
6 of 8 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-4882 branch January 29, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants