Fix rviz crash if launch later (backport #4882) #4883
Merged
+37
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Revival of #4871 targeting the main branch with improved code
get_parameter()
would not block the main thread. The combo box will now have value if it successfully gets the parameter, otherwise emptyDescription of documentation updates required from your changes
None
Description of how this change was tested
Extensively tested on tb3 simulation and all tests passed
Future work that may be required in bullet points
For Maintainers:
This is an automatic backport of pull request Fix rviz crash if launch later #4882 done by Mergify.