Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intraprocess bond::Bond::BondStatusCB use after free #4841

Open
wants to merge 8 commits into
base: ipc
Choose a base branch
from
Prev Previous commit
Next Next commit
LifecycleBondTest Use nav2_util::generate_internal_node
This wraps the creation of the node currently (ipc experiment branch)
sets the node option  .use_intra_process_comms(true)

Signed-off-by: Mike Wake <macwake@gmail.com>
  • Loading branch information
ewak committed Jan 28, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b57c9a300406dd1fad8e021b1032d692785ba639
2 changes: 1 addition & 1 deletion nav2_lifecycle_manager/test/test_bond.cpp
Original file line number Diff line number Diff line change
@@ -170,7 +170,7 @@ TEST(LifecycleBondTest, POSITIVE)

TEST(LifecycleBondTest, NEGATIVE)
{
auto node = std::make_shared<rclcpp::Node>("lifecycle_manager_test_service_client");
auto node = nav2_util::generate_internal_node("lifecycle_manager_test_service_client");
nav2_lifecycle_manager::LifecycleManagerClient client("lifecycle_manager_test", node);

// create node, now without bond setup to connect to. Should fail because no bond