Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag an error if someone submits a pip package which will mask a native package #30

Open
tfoote opened this issue Jan 27, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@tfoote
Copy link
Member

tfoote commented Jan 27, 2025

Our policy is that we should not submit a pip package that will mask a system package.

This is something that is hard to review manually as it requires you to search for the same or similar names in the ubuntu and debian packages. It would be good to search the other platforms too.

it's easy to overlook the masking such as ros/rosdistro#44287

There was a one line comment in the orignal PR mentioning the masking, but the reviewers didn't see it.

We can at least catch the ones with exactly the same name, even better would be to detect the python module because some package names get edited, due to things like debian naming policy restrictions being stricter than PyPI

Example: https://packages.ubuntu.com/oracular/python3-pymongo vs https://pypi.org/project/pymongo/

@tfoote tfoote added the enhancement New feature or request label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant