Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order priorities for the shifter, add link to new CI #970

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Re-order priorities for the shifter, add link to new CI #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions for_developers/shifters_instructions/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@ sidebar:
nav: "for_developers"
---

## These are the aspects the shifter shall keep under control
The shifter summarises the events of the week during the ROOT meeting. The hand-over
to the next shifter must be carefully handled.
## Shifter's duties
The members of the ROOT team have shift duties. A shift lasts for one week, from Monday to Monday.
The hand-over between shifters happens at the ROOT Project meeting on Mondays, and it has to be carefully handled.

### Keeping the builds green
The primary responsibility of the shifter is to "keep builds green", all tests need to succeed, all the time.
With top priority, the Shifter needs to fix the broken tests in the incremental and nightly builds and/or involve the relevant
experts to make that happen.

### Forum Posts
All forum posts have to be followed up. Some hours can be given to the community
to discuss the questions but an answer from the ROOT team must be given within 24 hours.
to discuss the questions but an answer from the ROOT team must be given within 24 hours or less.
It is responsibility of the shifter to make sure this happens, either answering or
involving the relevant expert.

### Failing tests
The shifter has the responsibility to "keep the builds green". He/she needs to fix
the broken tests in the incremental and nightly builds and/or involve the relevant
experts to make that happen.

### Open pull requests
The shifter has the responsibility to follow up PRs if the relevant expert did not,
either interacting with the contributor or involving the relevant expert. Again,
Expand All @@ -34,7 +34,8 @@ affected branches.

### Links to check daily

- [Nightly builds](https://github.com/root-project/root/actions/workflows/root-ci.yml?query=event%3Aschedule)
- [Nightly builds (old CI)](https://lcgapp-services.cern.ch/root-jenkins/view/ROOT%20Nightly/)
- [Forum](https://root-forum.cern.ch/latest)
- [Nightly builds](https://lcgapp-services.cern.ch/root-jenkins/view/ROOT%20Nightly/)
- [Unassigned issues](https://github.com/root-project/root/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee)
- [Unassigned pull requests](https://github.com/root-project/root/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee)
Loading