Add 404 page

README.md

@@ -262,6 +262,7 @@ Note: this step as well as tests are run automatically before releasing a new ve
 
 ## History
 
+- 1.0.4 Add 404 error message on "Not found pages".
 - 1.0.3 Get romcal-api version from the API. Support optional parameters when using romcal-api through an Express middleware.
 - 1.0.2 Readme fine-tuning.
 - 1.0.1 New logo for romcal-api.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "romcal-api",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "REST API for liturgical calendars in Catholic Roman rite (Western Church). Powered by romcal.",
   "main": "dist/src/index.js",
   "engines": {

src/routes/index.ts

@@ -4,6 +4,7 @@ import defaultConfig from '../config';
 import Calendar from './calendar/calendar';
 import Calendars from './calendars/calendars';
 import Locale from './locale/locale';
+import PageNotFound from './page-not-found/page-not-found';
 import Version from './version/version';
 
 const router = express.Router();
@@ -16,6 +17,7 @@ function initRouter(config?: {baseUrl: string}) {
   router.get(`${c.baseUrl}/calendars`, Calendars.getAllCalendars);
   router.get(`${c.baseUrl}/locales`, Locale.getAllLocales);
   router.get(`${c.baseUrl}/version`, Version.getVersion);
+  router.get(`${c.baseUrl}/*`, PageNotFound.get404Content);
 
   return router;
 }

src/routes/page-not-found/page-not-found.test.ts

@@ -0,0 +1,18 @@
+import request from 'supertest';
+import app  from '../../app';
+
+describe( `GET /*`, () => {
+  it('The API root returns a 404 error', async () => request(app())
+    .get('/')
+    .set('Accept', 'application/json')
+    .expect('Content-Type', /json/)
+    .expect(404)
+  );
+
+  it('Any URL not member of the API endpoints returns a 404 error', async () => request(app())
+    .get('/lorem-ipsum')
+    .set('Accept', 'application/json')
+    .expect('Content-Type', /json/)
+    .expect(404)
+  );
+});

src/routes/page-not-found/page-not-found.ts

@@ -0,0 +1,8 @@
+export default class PageNotFound {
+  static get404Content(_req, res) {
+    return res.status(404).send({
+      error: '404',
+      message: 'Page not found.',
+    });
+  }
+}