Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor fixes #34

wants to merge 3 commits into from

Conversation

phcorp
Copy link

@phcorp phcorp commented Apr 12, 2017

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none

two minor fixes:

  • filenames should be escaped in shell as they may contain invalid characters (i.e space, parenthesis)
  • a class filename did not match class name case, could be a problem on case-sensitive systems (maybe not Windows/OS X)
PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

...............................................................  63 / 123 ( 51%)
.S.................................................SSSSSSSSS    123 / 123 (100%)

Time: 41.48 seconds, Memory: 247.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 123, Assertions: 733, Skipped: 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant