Code refactoring #309
Closed
Code refactoring #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it improve the speed? |
|
Generally NumPy operations are exceptionally optimized and outperform general Python for loop based operations in terms of speed. Additionally, they enhance code conciseness. |
|
Yes I agree in general.
Did you observe a speedup in this case ?
…On Sun, Sep 3, 2023, 01:25 Dom ***@***.***> wrote:
Generally NumPy operations are exceptionally optimized and outperform
general Python for loop based operations in terms of speed. Additionally,
they enhance code conciseness.
—
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR437RSUSTLL2Q35AY7IJLXYO54ZANCNFSM6AAAAAA4I2GI5E>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I think it's better to keep the clearer naive code here. The list is at most 100k items and this will not provide a speedup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this minor code modification is to harness the power of optimized NumPy operations within the code.