Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GuiState instead of manual calculation for tooltips #884

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Use GuiState instead of manual calculation for tooltips #884

merged 2 commits into from
Feb 29, 2024

Conversation

boatbomber
Copy link
Member

This ends up being more reliable and less wasteful. GuiState seems to update more reliably than MouseEnter/Leave.
The alternative way to make this more reliable would be to run our manual mouse bounds check every frame, which I'd like to avoid.

@boatbomber boatbomber added scope: plugin Relevant to the Roblox Studio plugin size: small impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: needs review This work is mostly done, but just needs work to integrate and merge it. skip changelog PRs that may skip the changelog enforcement check labels Feb 29, 2024
@boatbomber boatbomber requested a review from Dekkonot February 29, 2024 22:21
@boatbomber boatbomber self-assigned this Feb 29, 2024
Dekkonot
Dekkonot approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, so the joke is on me if this breaks tooltips, but I assume you would have noticed them not working at all so I am going to approve it since the code looks sound.

@boatbomber boatbomber merged commit 26181a5 into rojo-rbx:master Feb 29, 2024
12 checks passed
@boatbomber boatbomber deleted the improve-tooltip-detection branch February 29, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dekkonot Dekkonot Dekkonot approved these changes

Assignees

@boatbomber boatbomber

Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small skip changelog PRs that may skip the changelog enforcement check status: needs review This work is mostly done, but just needs work to integrate and merge it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boatbomber @Dekkonot