Patch visualizer redesign #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atbomber/rojo into patch-vis-redesign
boatbomber
added
type: enhancement
…h-vis-redesign
Dekkonot
reviewed
Mar 25, 2024
|
Performance hit is negligible once generated (it's just an image texture, so only mem cost), but there's a small cost up front when building them. It's minimal though. To help mitigate it, I've added caching for the classicon pixel data so that we no longer need to get it from AssetService every time. |
boatbomber
removed
the
status: in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch visualizer component has a nicer tree design that is more readable while also more compact.
The confirming page has been slimmed down to just the necessary info:
The info for the latest patch has moved from text along the bottom into an icon in the top:
(No warnings)
(With warnings)
Clicking on the patch details icon will now open a detailed pop up, so that users can view details without resizing their main window:
(No warnings)
(With warnings)