Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A default.project.json with an omitted name field sets the name of its top-level instance to default after subsequent changes #916

Closed
kennethloeffler opened this issue May 14, 2024 · 0 comments · Fixed by #917
Assignees
Labels
scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen

Comments

@kennethloeffler
Copy link
Member

This issue is reproducible on latest mater, and is related to #858 .

Repro steps:

  1. Create a default.project.json and omit the name field. I used the following project: no_name_top_level_project.zip.
  2. Run rojo serve on the project, and visit http://localhost:34872/show-instances. Observe that the resulting instance has the correct name:
    image
  3. Make any change to the project file (I added a newline). Refresh http://localhost:34872/show-instances and observe that the instance's name has changed to default:
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen
Projects
None yet
2 participants