Skip to content

Commit

Permalink
Build tree ancestry correctly (#882)
Browse files Browse the repository at this point in the history
  • Loading branch information
boatbomber authored Feb 29, 2024
1 parent 5f51538 commit edf87bf
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions plugin/src/PatchTree.lua
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,7 @@ function Tree:buildAncestryNodes(previousId: string?, ancestryIds: { string }, p
-- Build nodes for ancestry by going up the tree
previousId = previousId or "ROOT"

for i = #ancestryIds, 1, -1 do
local ancestorId = ancestryIds[i]
for _, ancestorId in ancestryIds do
local value = instanceMap.fromIds[ancestorId] or patch.added[ancestorId]
if not value then
Log.warn("Failed to find ancestor object for " .. ancestorId)
Expand Down Expand Up @@ -200,7 +199,7 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
end

-- Gather ancestors from existing DOM
local ancestryIds, ancestryIndex = {}, 0
local ancestryIds = {}
local parentObject = instance.Parent
local parentId = instanceMap.fromInstances[parentObject]
local previousId = nil
Expand All @@ -211,8 +210,7 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
break
end

ancestryIndex += 1
ancestryIds[ancestryIndex] = parentId
table.insert(ancestryIds, 1, parentId)
knownAncestors[parentId] = true
parentObject = parentObject.Parent
parentId = instanceMap.fromInstances[parentObject]
Expand Down

0 comments on commit edf87bf

Please sign in to comment.