-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance README by Adding GitHub Repository Statistics Section and Project Title GIF [Fixed #173] #184
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the PR matches the requirements mentioned in the Contribution guide. The maintainer might get in touch to enusre quality. Thanks for your time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karthik3904 Can you please remove repo stats as it was already done by another contributor
Hi [@jvedsaqib ], I wanted to apologize for adding the GitHub repository stats without discussing it with you first. I have removed it in the latest commit. I appreciate your understanding, and I'll make sure to check in on future changes like this before proceeding. Thank you again for your patience and for considering my pull request! Best regards, |
@Karthik3904
|
Hi [@rohitinu6] I have completed the changes requested in issue 168, and I would like to summarize the work done: Updated the image: I have replaced the existing image with the screenshot of the webpage available in main.py, as requested. Added steps to run main.py: Clear instructions to run the Flask application have been added to the README. I have already included a GIF format for the title, which enhances the visuals of the project. However, for the following two changes: 3. Update the overview section 4. Fix the visibility of images in the performance metrics section I would like to raise these as a separate issue since I am focusing on completing my Hacktoberfest 2024 contributions. This will allow me to address the remaining tasks with proper attention in the next pull request. Could you kindly accept my current pull request so I can count this towards Hacktoberfest 2024? I will ensure the remaining tasks are completed promptly in the next PR. Thank you for understanding! Best regards, |
@Karthik3904 appreciate your work |
I made changes in overview section for adding steps executing main.py by using flask app only . |
Dear @rohitinu6 , I hope this message finds you well. I kindly request you to review and merge my pull request at your earliest convenience. Additionally, if the contribution meets your standards, please provide the hacktoberfest-accepted label. Thank you for your time and consideration. Best regards, |
I made the following changes. Thank You for your valuable time |
@Karthik3904 , please sync fork with the latest changes so as to merge the pr |
I've synced my fork with the latest changes. Thank you for accepting my PR! |
As I mentioned before I rised a separate issue for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karthik3904 Assigned you #196 .
Please merge the changes into this same pr.
Thanks and regards
Thank you for accepting the first set of changes! To keep things organized for Hacktoberfest2024, could you please merge this pull request as-is? I’ll be happy to create a new pull request for the second issue’s changes. This way, it will also help me meet the Hacktoberfest contribution guidelines. Thanks again for your understanding and support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
🎉🎉 Thank you for your contribution! Your PR #184 has been merged! 🎉🎉 |
Please Merge and close this Pull Request and i rised another PR and made the changes @Mayureshd-18 mentioned kindly provide labels merge and close that PR also Thank You for your support |
closes #173
closes #168
Description:
This pull request includes the following enhancements to the project's README:
Recording.2024-10-24.183937.mp4
Added GitHub Repository Statistics:
These stats will provide a quick overview of the repository's activity and engagement, making it more informative for potential contributors.
These improvements aim to make the README more engaging and informative for users and contributors alike.
Please label this PR with:
Thank you for reviewing my contribution! Let me know if any further changes are required.