Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert categorical variables to numeric variables #114

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Convert categorical variables to numeric variables #114

merged 1 commit into from
Oct 14, 2024

Conversation

shristirwt
Copy link
Contributor

@shristirwt shristirwt commented Oct 14, 2024 •
edited by jvedsaqib
Loading

Issue Reference: Fixes #111

Description of changes: The categorical variables were converted to numeric ones for plotting

Screenshot 2024-10-14 170805

@shristirwt shristirwt changed the title Categorical variables to numeric Convert categorical variables to numeric variables Oct 14, 2024
@shristirwt
Copy link
Contributor Author

I have tried every way possible to correct the issue but nothing is working

@jvedsaqib
Copy link
Collaborator

jvedsaqib commented Oct 14, 2024 •
edited
Loading

I have tried every way possible to correct the issue but nothing is working

Hey @shristirwt
Can you please elaborate?

Also edit your 1st comment and add keywords like fixes/closes before the issue number

@shristirwt
Copy link
Contributor Author

shristirwt commented Oct 14, 2024 •
edited
Loading

I have tried every way possible to correct the issue but nothing is working

Hey @shristirwt Can you please elaborate?

Also edit your 1st comment and add keywords like fixes/closes before the issue number

@jvedsaqib I have made the changes.
I am talking about the checks i.e. PR Contribution Rules Check
I edited the PR many times but it did not fix it

Screenshot 2024-10-14 225929

@jvedsaqib
Copy link
Collaborator

@shristirwt It's done!

The action checks required a specific format. Thanks for pointing out this issue.
I've updated your PR comment, you can check it.

@jvedsaqib jvedsaqib added the level2 25 Points 🥈(GSSoC) label Oct 14, 2024
@shristirwt
Copy link
Contributor Author

@shristirwt It's done!

The action checks required a specific format. Thanks for pointing out this issue. I've updated your PR comment, you can check it.

Thank you so much

Mayureshd-18
Mayureshd-18 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 hacktoberfest Hacktober Collaboration labels Oct 14, 2024
@Mayureshd-18 Mayureshd-18 merged commit 1a45c08 into rohitinu6:main Oct 14, 2024
3 of 17 checks passed
shristirwt pushed a commit to shristirwt/Stock-Price-Prediction that referenced this pull request Oct 22, 2024
@Mayureshd-18
Merge pull request rohitinu6#114 from shristirwt/local
c59a8ae 
Convert categorical variables to numeric variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayureshd-18 Mayureshd-18 Mayureshd-18 approved these changes

@jvedsaqib jvedsaqib jvedsaqib approved these changes

Assignees
No one assigned
Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level2 25 Points 🥈(GSSoC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Convert categorical variables to numeric variables
3 participants
@shristirwt @jvedsaqib @Mayureshd-18