Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC certificate verification missing #76

Open
domwoe opened this issue Aug 17, 2022 · 3 comments
Open

IC certificate verification missing #76

domwoe opened this issue Aug 17, 2022 · 3 comments

Comments

@domwoe
Copy link

domwoe commented Aug 17, 2022

I noticed you're missing the certificate verification and found the draft PR #56.
What's the blocker here?

@Myse1f
Copy link
Contributor

Myse1f commented Aug 17, 2022

The verification in each request would degrade the performance.

Besides, the wasmer package requires python3.7 or above.

@domwoe
Copy link
Author

domwoe commented Aug 19, 2022

I worry that users may get a false sense of security using your agent.

You could add verification as an opt out feature. Note also, that it's only used for the read_state API when you actually get a result.

Besides using WASM you could also look for a BLS implementation in Python or a BLS implementation in Rust that could be called from Python using FFI.

@Myse1f
Copy link
Contributor

Myse1f commented Aug 19, 2022

Actually, we try to find other BLS implementations in Python, but all seem incompatible with the IC one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants