-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group by Knative Service #398
Comments
Hi @fabiob, this is interesting - thank you! I hadn't known KNative grouped Deployments like that. We don't have builtin support for this, but we're open to solutions that address it. Do you want to use data across different revisions in the same calculations, or should each revision's data be calculated standalone and you just transform the latest one into a standard name? (The latter is likely the easier approach as its a transformation at the end of the pipeline.) What are you evaluating in Robusta? Is it mostly the KRR functionality or also HolmesGPT? |
In a perfect world, I would like to have something like this on KRR: I think KRR can work best if it is able to group all the revisions into a single unit for recommendation purposes, so I was thinking on grouping pods by Knative Service when available (detectable by reading the pod label But any improvement would be very nice. |
Thank you, that makes sense! I don't have an ETA right now, this helps us plan what a good solution looks like. |
Hi! I'm using KRR for a few weeks now and it is helping me a lot! I'm even evaluating Robusta right now.
There's something I would like it to support, though: we use Knative for a lot of services, but the Knative Serving works by wrapping Kubernetes Deployments into Revisions. In practice, it means that for every change we make to the service, it creates a new Kubernetes Deployment to replace the previous.
Since KRR groups pods by either Statefulset or Deployment, it means the KRR recommendations are not grouped properly. I would love to see KRR grouping the pods by Knative Service when available.
If that's not possible, at least let me write some kind of transformation pattern on the grouping name: for Knative Services, we would just need to remove the
-\d+-deployment$
suffix from the deployment name, and the grouping would be correct.Thanks in advance!
The text was updated successfully, but these errors were encountered: