bindings: Disable extended analog sensor interfaces in java #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
added
Component: Bindings
There was a problem hiding this comment.
I approve these changes, suggesting an addition:
Even though the lines https://github.com/drdanz/yarp/blob/c12213441b0342e799bbaca49cfde1db1e3881b9/bindings/yarp.i#L771-L779 which define the "view" methods, are not causing problems, it would be better to also disable them such that we disable the interfaces completely.
traversaro
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
Ok, but I think that @nunoguedelha suggestion make sense to remove also the view stuff make sense.
drdanz
force-pushed
the
fix/java_bindings
branch
from
c122134 to
a79661b
Compare
|
@nunoguedelha done. |
Nicogene
added
Severity: Release Blocker
PR Status: Changelog - Not Required
|
Failure is unrelated. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC-Issue: #1770
