Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concert common rapps #61

Merged

Conversation

hughie
Copy link
Member

@hughie hughie commented Sep 8, 2015

P2P delivery 서비스를 위한 meta rapp추가

  • meta rapp
  • public_interface
    • subscriber 중 global maker list와 location list에 대한 확인이 필요
  • simulation을 위한 meta rapp추가

type: nav_msgs/OccupancyGrid
- name: map_metadata
type: nav_msgs/MapMetaData
- name: table_pose_list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be location_list and yocs_msgs/WaypointList

@jihoonl
Copy link
Collaborator

jihoonl commented Sep 9, 2015

And remove simulation rapp please. The rapp will be PRed with actual script.

@jihoonl
Copy link
Collaborator

jihoonl commented Sep 11, 2015

@hughie package.xml 에 <rocon_app>을 추가해 주세요.

@jihoonl
Copy link
Collaborator

jihoonl commented Sep 11, 2015

@hughie
Copy link
Member Author

hughie commented Sep 11, 2015

@jihoonl package.xml을 추가하였습니다.

@@ -27,5 +27,6 @@
<rocon_app>rapps/notice_meta/notice.rapp</rocon_app>
<rocon_app>rapps/notice_nao/notice_nao.rapp</rocon_app>
<rocon_app>rapps/room_checker/room_checker.rapp</rocon_app>
<rocon_app>rapps/p2p_delivery/p2_delivery.rapp</rocon_app>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2_delivery 오타있습니다. 수정하면 바로 Merge하겠습니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoonl 오타라니.. 😅
수정했습니다.

@jihoonl
Copy link
Collaborator

jihoonl commented Sep 15, 2015

👍

jihoonl added a commit that referenced this pull request Sep 15, 2015
@jihoonl jihoonl merged commit 2ff3cee into robotics-in-concert:concert_common_rapps Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants