Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest IDE version (2024.2) #162

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

Elhussein-Hamed
Copy link
Contributor

Added the support for IDE version 2024.2.

@Elhussein-Hamed
Copy link
Contributor Author

@robohorse Could you please check if anything else needs to be added to support versions 2024.2.*

Copy link
Owner

@robohorse robohorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job! 👍 Thanks a lot. I'll publish a new build soon

@robohorse robohorse enabled auto-merge September 22, 2024 12:53
@robohorse robohorse disabled auto-merge September 22, 2024 12:54
@robohorse robohorse merged commit db41c50 into robohorse:main Sep 22, 2024
1 check passed
@robohorse
Copy link
Owner

hey @Elhussein-Hamed , you changes are live. Technically it should be supported out of the box as we have this property ... but let's see if we should define the latest IDE build as a target one 🤔 IDK honestly 🙈

@Elhussein-Hamed
Copy link
Contributor Author

@robohorse Yes you are right. I can see that on the plugin page, it does not have an 'unitl build' version. Sorry I followed what I usually do with my plugin as I don't have 'until build' defined but it takes it to be the target IDE version so I thought that the same applies to your plugin.

That makes my changes unnecessary, so feel free to revert them if you wish.

Side note: My plugin depends on yours :) So thanks for this amazing plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants