Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting: 🧹 -> 📦 project formatting,ruff,bandit,mypy configurations are added #51

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

onuralpszr
Copy link
Collaborator

@onuralpszr onuralpszr commented Sep 17, 2024

Description

  • line length is 120 (added based on previous black config)
  • chore: 🧹 mypy fixes added
  • refactor: 🧹 -> 📦 project formatting,cleanups,import errors fixed
  • feat(github): ⭐ basic python .gitattributes with extras added
  • refactor: 🧹 update type hints and clean up docstrings across multiple files
  • black and flake removed and replace via ruff and add as dev-dependency
  • refactor: 🧹 update numpy random choice method and enhance reproducibility settings
  • Documentation also reviewed and test (mkdocs serve) formatting didn't break any documentation based on visible documentation

Enabled Rules

pre-commit report

trim trailing whitespace.................................................Passed
check that executables have shebangs.................(no files to check)Skipped
check toml...............................................................Passed
check for case conflicts.................................................Passed
check for added large files..............................................Passed
detect private key.......................................................Passed
pretty format json.......................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
bandit...................................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
mypy.....................................................................Passed

Tox - Pytest Reports

  py39: OK (10.04=setup[6.20]+cmd[3.84] seconds)
  py310: OK (6.96=setup[3.43]+cmd[3.53] seconds)
  py311: OK (7.18=setup[3.52]+cmd[3.66] seconds)
  py312: OK (7.07=setup[3.34]+cmd[3.73] seconds)
  congratulations :) (31.31 seconds)

Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr onuralpszr added the enhancement New feature or request label Sep 17, 2024
@onuralpszr onuralpszr self-assigned this Sep 17, 2024
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr onuralpszr changed the title formatting: project formatting,ruff,bandit,mypy configurations are added formatting: 🧹 -> 📦 project formatting,ruff,bandit,mypy configurations are added Sep 17, 2024
…lity settings and NPY setting added

Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr onuralpszr marked this pull request as ready for review September 17, 2024 19:54
@SkalskiP SkalskiP merged commit 01265e7 into develop Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants