From e73d8fbf1132aeda1cfc6d83d64462606e185f52 Mon Sep 17 00:00:00 2001
From: robiningelbrecht <robiningelbrecht@users.noreply.github.com>
Date: Fri, 24 Jan 2025 09:13:28 +0100
Subject: [PATCH] ISSUE-187: Fix bug where eddington is rendered for non
 existing activity types

---
 templates/html/eddington.html.twig            |  12 ++++++----
 ...--testHandle--buildhtmleddington.html.html |  22 +++++++++---------
 tests/strava.db                               | Bin 552960 -> 552960 bytes
 3 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/templates/html/eddington.html.twig b/templates/html/eddington.html.twig
index ef8fbb25..5762a21d 100644
--- a/templates/html/eddington.html.twig
+++ b/templates/html/eddington.html.twig
@@ -22,11 +22,13 @@
                     <div class="mb-4 border-b border-gray-200">
                         <ul class="flex flex-wrap -mb-px text-sm font-medium text-center" id="activityTypeTab" data-tabs-toggle="#activityTypeTabContent" role="tablist">
                             {% for activityType in activityTypes %}
-                                <li class="mr-2" role="presentation">
-                                    <a href="#eddington" data-tabs-target="#{{ activityType.value }}" role="tab" aria-controls="{{ activityType.value }}" class="inline-flex items-center justify-center p-2 border-b-2 rounded-t-lg hover:text-gray-600 hover:border-gray-300 aria-selected:text-strava-orange aria-selected:border-strava-orange group">
-                                        {{ activityType|trans }} ({{ eddingtons[activityType.value].getNumber() }})
-                                    </a>
-                                </li>
+                                {% if eddingtons[activityType.value] is defined %}
+                                    <li class="mr-2" role="presentation">
+                                        <a href="#eddington" data-tabs-target="#{{ activityType.value }}" role="tab" aria-controls="{{ activityType.value }}" class="inline-flex items-center justify-center p-2 border-b-2 rounded-t-lg hover:text-gray-600 hover:border-gray-300 aria-selected:text-strava-orange aria-selected:border-strava-orange group">
+                                            {{ activityType|trans }} ({{ eddingtons[activityType.value].getNumber() }})
+                                        </a>
+                                    </li>
+                                {% endif %}
                             {% endfor %}
                         </ul>
                     </div>
diff --git a/tests/Domain/Strava/BuildHtmlVersion/__snapshots__/BuildHtmlVersionCommandHandlerTest--testHandle--buildhtmleddington.html.html b/tests/Domain/Strava/BuildHtmlVersion/__snapshots__/BuildHtmlVersionCommandHandlerTest--testHandle--buildhtmleddington.html.html
index 105f5939..0c20ef93 100644
--- a/tests/Domain/Strava/BuildHtmlVersion/__snapshots__/BuildHtmlVersionCommandHandlerTest--testHandle--buildhtmleddington.html.html
+++ b/tests/Domain/Strava/BuildHtmlVersion/__snapshots__/BuildHtmlVersionCommandHandlerTest--testHandle--buildhtmleddington.html.html
@@ -25,17 +25,17 @@
             <div class="p-4 bg-white border border-gray-200 rounded-lg shadow-sm sm:p-6">
                                     <div class="mb-4 border-b border-gray-200">
                         <ul class="flex flex-wrap -mb-px text-sm font-medium text-center" id="activityTypeTab" data-tabs-toggle="#activityTypeTabContent" role="tablist">
-                                                            <li class="mr-2" role="presentation">
-                                    <a href="#eddington" data-tabs-target="#Ride" role="tab" aria-controls="Ride" class="inline-flex items-center justify-center p-2 border-b-2 rounded-t-lg hover:text-gray-600 hover:border-gray-300 aria-selected:text-strava-orange aria-selected:border-strava-orange group">
-                                        Rides (6)
-                                    </a>
-                                </li>
-                                                            <li class="mr-2" role="presentation">
-                                    <a href="#eddington" data-tabs-target="#Run" role="tab" aria-controls="Run" class="inline-flex items-center justify-center p-2 border-b-2 rounded-t-lg hover:text-gray-600 hover:border-gray-300 aria-selected:text-strava-orange aria-selected:border-strava-orange group">
-                                        Runs (1)
-                                    </a>
-                                </li>
-                                                    </ul>
+                                                                                                <li class="mr-2" role="presentation">
+                                        <a href="#eddington" data-tabs-target="#Ride" role="tab" aria-controls="Ride" class="inline-flex items-center justify-center p-2 border-b-2 rounded-t-lg hover:text-gray-600 hover:border-gray-300 aria-selected:text-strava-orange aria-selected:border-strava-orange group">
+                                            Rides (6)
+                                        </a>
+                                    </li>
+                                                                                                                                <li class="mr-2" role="presentation">
+                                        <a href="#eddington" data-tabs-target="#Run" role="tab" aria-controls="Run" class="inline-flex items-center justify-center p-2 border-b-2 rounded-t-lg hover:text-gray-600 hover:border-gray-300 aria-selected:text-strava-orange aria-selected:border-strava-orange group">
+                                            Runs (1)
+                                        </a>
+                                    </li>
+                                                                                    </ul>
                     </div>
                                 <div id="activityTypeTabContent">
                                             <div id="Ride" role="tabpanel" aria-labelledby="Ride-tab">
diff --git a/tests/strava.db b/tests/strava.db
index 8c49ec7028bafb799f95626eaf3fb30df1d64897..8f54fd3d5b0392b4f56d8c768400456d27f351bf 100644
GIT binary patch
delta 659
zcmY+>$x0(p6vpv;og(58H4ZIWWjRmLq&hJghiJF+7^iOMse5CCpn@xh#2Iv>)FKN(
z#1{yHn4S0n{Rn~&;Z8*Vy0KjR;5&!!!i5uj)Pj%NX--=BTnKT5Z}=yYmoLt$^r-Op
z_5A<5Bv-zp&g;~@uKF0C#R#aHF{RiNKexU(<3%YpE)}bJ8T-+EP;3dGP2*Ydm^;yQ
zij0ez_;lT&yX_9AT{o4tRFC=X-IsCiRgJu=Qu?o2tY>~p(-I$_zzD`LgIUaB9t&8+
zAN<7t`q78p(9??a1XSWArZA0BRH6dq7{(C%7(^9nPz^hNqX>m4fQEb&qXeZWg9A>C
z;}<ruAw+0$MQVXHhAnL40Q=a(E_M(^0Ec)#SSNbWg>HCI3pZS7LL(aBMLp{99Xguf
zLkn7k$PqsXKhcJEbU=9*x>=Ql?sQ@rQej03Y%uRLnKO`!Y-B|e*W^>u?WsIgW%kiY
SSRxA1h(RpkA}3+X`u!VC#b`nR

delta 657
zcmY+<%TE(g6vy#<DYS-AQ)zwinCaLSAMHqI+FGbWE26x$KC9vbUkhE5u!NZwq#<k|
zlhB><KOh>D?u`F{e*y`A0t<JB)Nct%$Hgc2oO6FSxyRnu?0s#kr+cR?gs9>iK8ceh
zeLG>c?UcVQ{O<Rs!p2a}NaoCRd*0_*s^-iqp{~|6?{yB9nDbQ$xQ87_$vq|1*-AQp
zm8?7CArp1J44w#@Ni(A-4c&Bwm({HM?a%+()rMMcs8SZUi@vFk{Q5GkAd2QTHY}{*
zGuF}Ea1EDm5d(;!f>kWn4s02>RLVFKc!4R5;TFbm8+R~)N!-H&Jj5eB#yp<m8J?nq
zC%BIy?qUwJn87sO<AV^jX<HiBBF#Iz#TzW(HD2K*29bo0s~ANd1>D39jNm$Qh~NS=
zgfWaEWN{4{q>+LtM5iz)6!h1Alw~Aynlk8eiaK!IcXKxHL+C><&f-kHt0MpSzZYbn
bF1O@{D$iFpcO}~3K|4C&t#9u7mVW&Mb?9cq