Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option perform-by-domain, to create wildcard SSL with base doma… #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

decryptus
Copy link
Collaborator

…in in the same certificate

@robin-thoni
Copy link
Owner

Not really sure to understand what it's doing. Could you elaborate on this?
Also, as I said in some previous issues, I don't use this plugin anymore, as I moved to bind.

@decryptus
Copy link
Collaborator Author

Hi robin-thoni,
There is problem when in the same certificate you have wildcard and root domain, so the patch add two TXT records.
For more information:
https://community.letsencrypt.org/t/confusing-on-root-domain-with-wildcard-cert/56113/4

I understand you don't use this plugin anymore, but for me, it's very useful ;)
So, I can maintain it on github and pypi too, if you agree.

@robin-thoni
Copy link
Owner

I see the problem.

So, I can maintain it on github and pypi too, if you agree.

Might be a good idea ;)

@decryptus
Copy link
Collaborator Author

Hi @robin-thoni so, what do you want to do? ;)

@robin-thoni
Copy link
Owner

Oh sorry, I forgot that issue. I'll give you rights on this repo and I'll check how to it on pypi later today. Ping me tomorrow if you have no news ;)

@robin-thoni
Copy link
Owner

Done!

@decryptus
Copy link
Collaborator Author

Yes, I see that, thank you! I will do my best to maintain this project.

@rysson
Copy link

rysson commented Feb 17, 2023

@decryptus, It's great news. Your PR is very imported por me, I used it for years.
If you have rights on this repo why yours PR is still not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants