Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tencentcloud remote store #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fengxsong
Copy link

This PR support tencentcloud as remote store. besides it does the following changes

  1. I've add a StoreCreator interface, then every remote stores can focused on their own implementation without taking too much changes in the NewStore function. (the changes might be somewhat significant in a single PR, and, of course, you might feel that these changes are unnecessary :( )
  2. support run this controller with CLI arguments.
  3. it's quite noise as there are too much debug/trace logs

Signed-off-by: fengxsong <fengxsong@outlook.com>
Signed-off-by: fengxsong <fengxsong@outlook.com>
Signed-off-by: fengxsong <fengxsong@outlook.com>
@robertlestak
Copy link
Owner

@fengxsong this is awesome thank you! conceptually, the StoreCreator interface is exactly what i was going for - as you said, let the providers focus on their cloud-specific business logic.

as this is quite a significant PR (and I have a day job 😄) please allow me some time to review and test in my environment, but do know this is on my radar and i am excited to get this merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants