Fix Psalm issues

[msmakouz]

Q	A
Bugfix?	❌
Breaks BC?	❌
New feature?	❌

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of consumer_id and message_group_id in queue creation to avoid issues with null or empty strings.

[coderabbitai]

Walkthrough

The recent update enhances the functionality of the toArray methods within the AMQP and SQS queue creation information classes. Specifically, it introduces a condition to check for null or empty strings before assigning values to consumer_id in AMQP and message_group_id in SQS. This refinement ensures more robust data handling and validation in the queue setup process.

Changes

File Path	Change Summary
.../AMQPCreateInfo.php, .../SQSCreateInfo.php	Updated toArray method to check for null or empty string before setting consumer_id and message_group_id.

🐇✨
In the land of code and queue,
A rabbit hopped, and wisdom grew.
"Check for null, or string so bare,
Before you place values there."
With every hop, the code did mend,
Thanks to the rabbit, our fluffy friend.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 470c572 and b9dd911.

Files selected for processing (2)

• src/Queue/AMQPCreateInfo.php (1 hunks)
• src/Queue/SQSCreateInfo.php (1 hunks)

Additional comments not posted (2)

src/Queue/SQSCreateInfo.php (1)

88-88: The condition for including message_group_id in the result array is correctly updated to check for both null and non-empty string values. This is a good practice to ensure that only valid, meaningful values are included, aligning with the PR's objective of improving code quality by addressing issues identified by Psalm.

However, consider adding a brief comment above this condition explaining why this check is necessary. This can improve code readability and maintainability, especially for future contributors who might not be familiar with the context of this change.

src/Queue/AMQPCreateInfo.php (1)

92-92: The update to conditionally include consumer_id in the result array only if it's not null and not an empty string is a solid improvement. It ensures that only valid identifiers are included, which is crucial for maintaining data integrity and preventing potential issues.

As with the previous file, adding a comment explaining the rationale behind this condition could enhance the code's readability and maintainability. It helps future maintainers understand the purpose of this check without needing to trace back through the commit history or PR discussions.