Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add typos check action. #61

Merged
merged 3 commits into from
Sep 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: DoozyX/clang-format-lint-action@v0.11
- uses: DoozyX/clang-format-lint-action@v0.18.2
with:
source: '.'
extensions: 'h,cpp,c'
clangFormatVersion: 11
clangFormatVersion: 11.0.0
# inplace: True
# - uses: EndBug/add-and-commit@v9
# with:
Expand All @@ -54,3 +54,11 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ludeeus/action-shellcheck@master
typos:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
submodules: true
- uses: crate-ci/typos@master
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ if(WITH_SEXP_TESTS)
set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
# do not install gtest
set(INSTALL_GTEST OFF CACHE BOOL "" FORCE)
# explicitely disable unneeded gmock build
# explicitly disable unneeded gmock build
set(BUILD_GMOCK OFF CACHE BOOL "" FORCE)

FetchContent_MakeAvailable(googletest)
Expand Down
2 changes: 1 addition & 1 deletion README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Prof. Ronald Rivest and Prof. Butler Lampson of MIT LCS (now CSAIL).

This library differs from the original C implementation in the following ways:

* It aims to be reuseable in C++ implementations and is importable via CMake.
* It aims to be reusable in C++ implementations and is importable via CMake.
* It includes a test suite for correctness testing and tests against malformed
S-Expressions.
* It supports, and is tested against, all major platforms, including:
Expand Down
4 changes: 4 additions & 0 deletions _typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[files]
extend-exclude = [
"tests/abi/libsexpp.0.abi"
]
4 changes: 2 additions & 2 deletions include/sexpp/sexp.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#include "sexp-public.h"
#include "sexp-error.h"

// We are implementing char traits for octet_t with trhe following restrictions
// We are implementing char traits for octet_t with the following restrictions
// -- limit visibility so that other traits for unsigned char are still possible
// -- create template specializatio in std workspace (use workspace specialization
// is not specified and causes issues at least with gcc 4.8
Expand Down Expand Up @@ -454,7 +454,7 @@ class SEXP_PUBLIC_SYMBOL sexp_output_stream_t : sexp_depth_manager {
public:
const uint32_t default_line_length = 75;
enum sexp_print_mode { /* PRINTING MODES */
canonical = 1, /* standard for hashing and tranmission */
canonical = 1, /* standard for hashing and transmission */
base64 = 2, /* base64 version of canonical */
advanced = 3 /* pretty-printed */
};
Expand Down
2 changes: 1 addition & 1 deletion tests/scripts/tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ test_install_script() {

# ......................................................................
# Check sexp client application
# THese are the examples from README.adoc
# These are the examples from README.adoc
test_sexp_cli() {
echo "==> SEXP client application test"

Expand Down
2 changes: 1 addition & 1 deletion tests/src/exception-tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ TEST_F(ExceptionTests, IllegalCharacter)
"SEXP ERROR: illegal character '?' (0x3f) at position 16");
}

TEST_F(ExceptionTests, UnexpectedEofAfterQoute)
TEST_F(ExceptionTests, UnexpectedEofAfterQuote)
{
do_scan_with_exception("(\")\n", "SEXP ERROR: unexpected end of file at position 4");
}
Expand Down
2 changes: 1 addition & 1 deletion tests/src/primitives-tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ TEST_F(PrimitivesTests, Base64Ofoctet_t)
do_test_advanced("|YWJj|", "abc");
}

TEST_F(PrimitivesTests, Base64OfVerbatium)
TEST_F(PrimitivesTests, Base64OfVerbatim)
{
do_test_canonical("{MzphYmM=}", "3:abc");
do_test_advanced("{MzphYmM=}", "abc");
Expand Down