Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created abi test workflow #57

Merged
merged 4 commits into from
Jun 16, 2024
Merged

Created abi test workflow #57

merged 4 commits into from
Jun 16, 2024

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Jun 15, 2024

No description provided.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (758d7bd) to head (e1aa7db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          10       10           
  Lines         692      692           
=======================================
  Hits          690      690           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx force-pushed the maxirmx-add-abi-tests branch 3 times, most recently from b2c825b to 6ad1419 Compare June 15, 2024 11:43
@maxirmx maxirmx linked an issue Jun 15, 2024 that may be closed by this pull request
@maxirmx maxirmx force-pushed the maxirmx-add-abi-tests branch 2 times, most recently from 65f4fc0 to 09ec2da Compare June 15, 2024 11:58
@maxirmx maxirmx requested review from antonsviridenko and ni4 June 15, 2024 11:59
@maxirmx maxirmx self-assigned this Jun 15, 2024
@maxirmx maxirmx marked this pull request as ready for review June 15, 2024 12:01
@maxirmx
Copy link
Member Author

maxirmx commented Jun 15, 2024

cc @remicollet

Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just minor CI comment.

.github/workflows/build-and-test-rh.yml Outdated Show resolved Hide resolved
@maxirmx maxirmx force-pushed the maxirmx-add-abi-tests branch from 09ec2da to e1aa7db Compare June 16, 2024 11:26
@maxirmx maxirmx requested a review from ni4 June 16, 2024 11:31
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maxirmx maxirmx merged commit 7197ff2 into main Jun 16, 2024
69 checks passed
@maxirmx maxirmx deleted the maxirmx-add-abi-tests branch June 16, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that ABI is not changed once #54 is merged
2 participants