-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update formula to v0.17.1 #38
Conversation
a4f4349
to
27dcc7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ni4 ! There seems to be a failure to build on Apple on macOS 14 according to GitHub, but we can fix it later.
Errm, where do you see it? Probably I'm missing something. I could try to reproduce that in Parallels (as I'm on 13.x) once this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this formula does not work as it was expected
:recommended is supposed to generate --without-botan
option.
Not sure what would happen if it is overwritetn with --with-botan
but you can see that botan is not installed and rnp build fails: https://github.com/rnpgp/homebrew-rnp/actions/runs/9127459830
There may be some clue here https://docs.brew.sh/Formula-Cookbook#check-for-dependencies but I did not understand what this manual says
@maxirmx Thanks for the hint! Will fix that to work as expected. They really have a bit confusing manual. |
27dcc7f
to
e54cf37
Compare
e54cf37
to
8dc02fa
Compare
@maxirmx I removed optional backend selection as it is not something which is supported in homebrew-core as per documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ni4 , I bumped actions/cache version
No description provided.