Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formula to v0.17.1 #38

Merged
merged 2 commits into from
May 21, 2024
Merged

Update formula to v0.17.1 #38

merged 2 commits into from
May 21, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented May 16, 2024

No description provided.

@ni4 ni4 force-pushed the ni4-update-to-v0.17.1 branch 2 times, most recently from a4f4349 to 27dcc7f Compare May 17, 2024 11:24
@ni4 ni4 marked this pull request as ready for review May 17, 2024 12:19
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ni4 ! There seems to be a failure to build on Apple on macOS 14 according to GitHub, but we can fix it later.

@ni4
Copy link
Contributor Author

ni4 commented May 17, 2024

Thanks @ni4 ! There seems to be a failure to build on Apple on macOS 14 according to GitHub, but we can fix it later.

Errm, where do you see it? Probably I'm missing something. I could try to reproduce that in Parallels (as I'm on 13.x) once this is merged.

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this formula does not work as it was expected

:recommended is supposed to generate --without-botan option.
Not sure what would happen if it is overwritetn with --with-botan but you can see that botan is not installed and rnp build fails: https://github.com/rnpgp/homebrew-rnp/actions/runs/9127459830

There may be some clue here https://docs.brew.sh/Formula-Cookbook#check-for-dependencies but I did not understand what this manual says

@ni4
Copy link
Contributor Author

ni4 commented May 18, 2024

@maxirmx Thanks for the hint! Will fix that to work as expected. They really have a bit confusing manual.

@ni4 ni4 force-pushed the ni4-update-to-v0.17.1 branch from 27dcc7f to e54cf37 Compare May 20, 2024 10:46
@ni4 ni4 force-pushed the ni4-update-to-v0.17.1 branch from e54cf37 to 8dc02fa Compare May 21, 2024 15:24
@ni4 ni4 requested a review from maxirmx May 21, 2024 17:12
@ni4
Copy link
Contributor Author

ni4 commented May 21, 2024

@maxirmx I removed optional backend selection as it is not something which is supported in homebrew-core as per documentation.

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ni4 , I bumped actions/cache version

@maxirmx maxirmx merged commit 546ec48 into main May 21, 2024
2 checks passed
@maxirmx maxirmx deleted the ni4-update-to-v0.17.1 branch May 21, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants