Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]factorize “the estimated predicted error covariance” #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions filterpy/kalman/CubatureKalmanFilter.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,9 @@ def predict(self, dt=None, fx_args=()):

# evaluate cubature points
for k in range(self._num_sigmas):
self.sigmas_f[k] = self.fx(sigmas[k], dt, *fx_args)
sigmas_f[k] = self.fx(sigmas[k], dt, *fx_args)

self.x, self.P = ckf_transform(self.sigmas_f, self.Q)
self.x, self.P = ckf_transform(sigmas_f, self.Q)

# save prior
self.x_prior = self.x.copy()
Expand Down Expand Up @@ -359,6 +359,8 @@ def update(self, z, R=None, hx_args=()):
elif isscalar(R):
R = eye(self.dim_z) * R

self.sigmas_f = spherical_radial_sigmas(self.x, self.P)

for k in range(self._num_sigmas):
self.sigmas_h[k] = self.hx(self.sigmas_f[k], *hx_args)

Expand Down