Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Rzlist methods. fixes rizinorg/rz-ghidra#337 #338

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

treseco
Copy link
Contributor

@treseco treseco commented Dec 22, 2023

Fixes compile errors resulting from the renaming of rz_list_iter_t members in rizin dev branch here. New version calls methods instead of accessing members.

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed compilation of the Cutter plugin is because Cutter needs to be updated. Good to merge as is.

root/cutter/src/core/RizinCpp.h:58:67: error: ‘RzListIter’ {aka ‘struct rz_list_iter_t’} has no member named ‘data’
#9 32.52    58 |         for (it = list->head; it && ((x = static_cast<type *>(it->data))); it = it->n)
#9 32.52       |                                                                   ^~~~
#9 32.52 /root/cutter/src/core/Cutter.cpp:2554:5: note: in expansion of macro ‘CutterRzListForeach’
#9 32.52  2554 |     CutterRzListForeach (core->dbg->plugins, iter, RzDebugPlugin, plugin) {
#9 32.52       |     ^~~~~~~~~~~~~~~~~~~
#9 32.52 /root/cutter/src/core/RizinCpp.h:58:85: error: ‘RzListIter’ {aka ‘struct rz_list_iter_t’} has no member named ‘n’
#9 32.52    58 |         for (it = list->head; it && ((x = static_cast<type *>(it->data))); it = it->n)
#9 32.52       |                                                                                     ^
#9 32.52 /root/cutter/src/core/Cutter.cpp:2554:5: note: in expansion of macro ‘CutterRzListForeach’
#9 32.52  2554 |     CutterRzListForeach (core->dbg->plugins, iter, RzDebugPlugin, plugin) {
#9 32.52       |     ^~~~~~~~~~~~~~~~~~~
#9 32.52 /root/cutter/src/core/Cutter.cpp: In member function ‘QList<ProcessDescription> CutterCore::getProcessThreads(int)’:
#9 32.52 /root/cutter/src/core/RizinCpp.h:58:67: error: ‘RzListIter’ {aka ‘struct rz_list_iter_t’} has no member named ‘data’
#9 32.52    58 |         for (it = list->head; it && ((x = static_cast<type *>(it->data))); it = it->n)
#9 32.52       |                                                                   ^~~~
#9 32.52 /root/cutter/src/core/Cutter.cpp:2853:5: note: in expansion of macro ‘CutterRzListForeach’
#9 32.52  2853 |     CutterRzListForeach (list, iter, RzDebugPid, p) {
#9 32.52       |     ^~~~~~~~~~~~~~~~~~~

@XVilka XVilka merged commit 3741188 into rizinorg:dev Dec 25, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants