Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger stepover and shortcut fixes #3407

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Debugger stepover and shortcut fixes #3407

merged 2 commits into from
Jan 30, 2025

Conversation

karliss
Copy link
Member

@karliss karliss commented Jan 30, 2025 •
edited
Loading

Your checklist for this pull request

Detailed description

  • F5 shortcut was used for both debug continue and "refresh all". Switch the refresh all to Ctrl/Cmd + R to avoid the conflict. That's what docs already said, it was just that QKeySequence::Refresh corresponded to Ctrl+R on some platforms but F5 on others.
  • Accept the currently inputed text in debug arg dialog using "Ctrl+Enter"
  • Add debug stop action, to Debug menu under the main menu bar
  • Fix debug step over and and step out

Test plan (required)

Shortcuts

  • open simple executable
  • F9 start debugger
  • Enter- to confirm the debugger beta message
  • Ctrl+Enter to confirm the argument dialog
  • set breakpoint few instruction ahead
  • press F5 -> expected continue until the set breakpoint is hit

Step over/step out:

  • start debugger
  • reach a code just before call instruction
  • when the debugger is stopped on call instruction use "step over"
  • expected debugger to stop at the instruction after call instruction
  • reach call instruction
  • stepinto
  • press step out -> expect returning to previous function

Closing issues

@karliss karliss marked this pull request as ready for review January 30, 2025 13:10
@karliss karliss changed the title Debugger bugfixes Debugger stepover and shortcut fixes Jan 30, 2025
@karliss
Debug shortcut polish
be0f4ff 
* Avoid  F5(continue debug) shortctut conflicting with  refresh all by switching  QKeySequence:Refresh to Ctrl+R.
* Confirm debug arg dialog using Ctrl+Return
* Add Stop debug action to debug menu in main menu bar
@karliss
Fix debug step over and out.
9d89933 
The old code didn't make sense: capturing by reference function local variable in a lambda which will be executed as async task, checking result of async task before the task was even started.
@karliss karliss merged commit cb6035a into rizinorg:dev Jan 30, 2025
14 checks passed
@karliss karliss deleted the debug-impr branch January 31, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karliss @wargio