Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust source and content type for inventories #323

Open
lpugin opened this issue Dec 11, 2024 · 3 comments
Open

Adjust source and content type for inventories #323

lpugin opened this issue Dec 11, 2024 · 3 comments
Assignees

Comments

@lpugin
Copy link

lpugin commented Dec 11, 2024

Inventories in Muscat bring two new record types for sources to be adjusted here
https://github.com/rism-digital/muscatplus_indexer/blob/7d29c45540012cb54fd76ec3df8ed4b78ec92bb0/indexer/helpers/identifiers.py#L25

  • 12: inventory
  • 13: inventory_edition

12 needs to be mapped to manuscript, and 13 to print source type.

The content type shows as Inventory, which is fine. However, it is missing a the translation and a content type (yellow) icon.

@lpugin
Copy link
Author

lpugin commented Dec 11, 2024

(unspecified source type and the blank green icon will disappear)

image

@ahankinson
Copy link
Contributor

This will probably disappear when the source is unpublished.

@lpugin
Copy link
Author

lpugin commented Dec 11, 2024

Yes. And no new source type will be needed when we publish them. Only the content type.

@ahankinson ahankinson self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants