From 5c588ef352cf9710481b439305f54af81d1ee479 Mon Sep 17 00:00:00 2001 From: zwang28 <70626450+zwang28@users.noreply.github.com> Date: Wed, 13 Dec 2023 13:13:22 +0800 Subject: [PATCH] chore: don't warn on object not found error (#13935) --- src/object_store/src/object/mod.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/object_store/src/object/mod.rs b/src/object_store/src/object/mod.rs index da846b7136a46..8e1ec690dd194 100644 --- a/src/object_store/src/object/mod.rs +++ b/src/object_store/src/object/mod.rs @@ -621,7 +621,11 @@ impl MonitoredObjectStore { .unwrap_or_else(|_| Err(ObjectError::internal("read timeout"))), }; - try_update_failure_metric(&self.object_store_metrics, &res, operation_type); + if let Err(e) = &res && e.is_object_not_found_error() && path.ends_with("manifest.json") { + // Metadata backup's manifest.json not found is expected. + } else { + try_update_failure_metric(&self.object_store_metrics, &res, operation_type); + } let data = res?; self.object_store_metrics