Simplify PMP code #738
Open
Simplify PMP code #738
+3
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline `pmpCheckPerms` and use `== Machine` instead of `match`. I think this is a lot easier to understand, and shorter.
arichardson
reviewed
Feb 14, 2025
| @@ -95,7 +84,7 @@ function pmpMatchEntry(addr: physaddr, width: xlenbits, acc: AccessType(ext_acce | |||
| match pmpMatchAddr(addr, width, rng) { | |||
| PMP_NoMatch => PMP_Continue, | |||
| PMP_PartialMatch => PMP_Fail, | |||
| PMP_Match => if pmpCheckPerms(ent, acc, priv) | |||
| PMP_Match => if pmpCheckRWX(ent, acc) | (priv == Machine & not(pmpLocked(ent))) | |||
There was a problem hiding this comment.
I guess the other options would be
- pass priv to pmpcheckRWX() and add
if priv == Machine & not(pmpLocked(ent)) then true else match ...? - change pmpCheckPerms to an if instead of a match().
But 2) seems unnecessary since there is only one caller of pmpCheckPerms() so we might as inline it. LGTM.
arichardson
approved these changes
Feb 14, 2025
jordancarlin
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline
pmpCheckPermsand use== Machineinstead ofmatch. I think this is a lot easier to understand, and shorter.