-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a DOWNLOAD_GMP option to build against a local GMP build #731
base: master
Are you sure you want to change the base?
Conversation
If we decide to use this I can add one for libz. However that dependency will go away soon and is commonly available so not sure if it's worthwhile |
I don't think it is worthwhile to add for zlib since (as you mentioned) it will be gone starting with the next Sail release. More worthwhile perhaps would be to have it automatically download the Sail compiler itself. That way there would be next to no dependences other than a compiler and cmake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! We should probably mention it in the README. Maybe use it in build_emulators.sh
?
20a95b2
to
61d8c5d
Compare
New version should address all comments raised so far. |
This downloads the latest release of GMP and builds it as part of the overall emulator build. This should make it easier to build sail without having to install system dependencies. Also change build_simulators.sh to download GMP by default to make it easier for users that don't manually configure the CMake build. See riscv#215
Now that we default to building libgmp, it makes more sense to increase job count to number of available CPUs since there is more parallelism.
61d8c5d
to
08c2ae6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we want to add a CI matrix entry that uses this option so it doesn't get broken in future?
Yes that would be good - let me do that as a follow-up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Agreed that we should test this in CI. Maybe just by running the build_emulators.sh
script.
This downloads the latest release of GMP and builds it as part of the overall emulator build. This should make it easier to build sail without having to install system dependencies.
See #215