Suggestions for the new no-relay template #76
Conversation
…template into victor/capossele/no-relay
| /// Generates a snark proof for the given elf and input. | ||
| /// When `RISC0_DEV_MODE` is set, executes the elf locally, | ||
| /// as opposed to sending the proof request to the Bonsai service. | ||
| pub fn generate_proof(elf: &[u8], input: Vec<u8>) -> Result<Proof> { | ||
| pub(crate) fn generate_proof(elf: &[u8], input: impl serde::Serialize) -> Result<Proof> { |
There was a problem hiding this comment.
So I think this function should be exposed by the ethereum-sdk; people might need it outside of the starter-template
There was a problem hiding this comment.
I don't think the utilities provided are ready for wider use as a public API, and so I am hesitant to encourage folks to use this as a library. I'd like to keep types like Proof internal for now if possible.
There was a problem hiding this comment.
My take on the current maturity of this code is that users should use it as an example, and copy it if it solves their problem. And we'll aim to move the into risc0 or the new risc0-ethereum repo soon.
| @@ -87,7 +87,7 @@ impl TryFrom<bonsai_sdk::responses::Groth16Seal> for Seal { | |||
|
|
|||
| /// Snark proof as generated by Bonsai. | |||
| #[derive(Clone, Debug)] | |||
| pub struct Proof { | |||
| pub(crate) struct Proof { | |||
There was a problem hiding this comment.
Same suggestion as for generate_proof. Wouldn't this be useful in the context of the ethereum-sdk?
| } | ||
|
|
||
| function set(uint256 number) internal { |
There was a problem hiding this comment.
Why removing this? I think the way it was before looked cleaner
There was a problem hiding this comment.
With test code, my style preference if general in favor of a bit more duplication if it means each test is more self contained. This also makes it more clear where the failure case is actually failing, instead of including additional lines of code that should never be reached.
Co-authored-by: Angelo Capossele <angelocapossele@gmail.com>
|
I've merged this into capossele/no-relay to consolidate any further effort there. Still open to make changes on any of the open comments above. |
I went about taking the new template for a test drive, and ran into a few issues.
This PR contains a number of suggestions I had from the process of trying to use and understand the template better.