This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
call closure when redis crashed #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deathkel I feel like this should be handled somewhere else, I don't believe it's the repository implementation responsibility to handle such exceptions. If you believe otherwise, would you please explain why this should be handled here? |
|
I use repository in my project.but in product environment， redis behave not 100% stable. I think my project should not down just because cache system crashed. I think it's the best place to hanlde the cache system error,since reoposity is dealing with Cache and Model. And It should hanlde this error automatically |
|
and we should log this error when it occurred |
* release/v5.0.1: Bump version Add missing laravel/helpers composer package
Update from upstream repo rinvex/repository
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.