make new release? #16
Conversation
|
I've reviewed the changes myself as well, making some small corrections along the way: da124c7 |
|
OK, so the native tests pass now. Need to make docker work now. |
|
TBH I'm slowly starting to give up on docker for "alpm-sys".. It doesn't even have any tests. It only tests compilation, which is checked with a local The appropriate way, it seems, would be to e.g. create a Dockerfile. But haven't touched docker for quite a while. |
|
Thoughts? |
|
Hi - sorry this is quite a big patch. I need to go through it all. |
|
@derekdreery yes, I understand. Took a considerable effort for me to do it as well. |
|
@derekdreery any news? If we can drop off testing in Docker for now, it'll be sad of course, but then again we wouldn't have to maintain the fork for now. Testing in docker could be added back later I guess, if libalpm starts compiling on stable Rust and somebody would be interested... Not sure of course. Thoughts? |
|
This is a very large patch, and I don't really have time to review. I recommend forking this project, and making a new crate on crates.io. I will try to review if I get some time in the future, but I don't know when that might be. |
|
@derekdreery would you prefer to fork the project on cargo/crates as well? I've done it here in Nov 2018 https://crates.io/crates/libalpm-fork because I've needed a newer version. Should it remain a fork on crates.io or you'd prefer to merge instead? |
|
By the way, I didn't tell it explicitly, but I'm using the project in an AUR helper that I'm building: https://github.com/vn971/rua |
Sorry for raising it like this... But are you aware of the existence of forks? If you could merge the functionality and make a new release, it'd be great!
The version in this pull request builds on stable Rust.
// I've temporarily forked the lib on crates.io using the name "libalpm-fork" (https://github.com/vn971/alpm) , but I'd happily delete it if upstream release will be made.