COO-5: disable custom config deprecation flag #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the custom config deprecation behavior flag to enable OBO to drop service discovery entirely. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
commented
Dec 3, 2024
| @@ -31,6 +31,8 @@ patches: | |||
| image: <IMG_PROMETHEUS_OPERATOR> | |||
| args: | |||
| - --prometheus-config-reloader=<IMG_PROMETHEUS_CONFIG_RELOADER> | |||
| # Refer https://github.com/prometheus-operator/prometheus-operator/pull/6955 | |||
| - -disable-unmanaged-prometheus-configuration | |||
There was a problem hiding this comment.
|
hmm can you elaborate as to why we want to disable that? |
rexagod
changed the title
|
@jan--f Owing to a certain behavior upstream, it wasn't possible to to disable SD by disabling I've also attached the ticket link for more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the custom config deprecation behavior flag to enable OBO to drop service discovery entirely.
JIRA: https://issues.redhat.com/browse/COO-5