feat: remediations #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopy-kat
commented
May 28, 2024
| @@ -55,7 +55,6 @@ library SentinelListLib { | |||
| next = self.entries[next]; | |||
| self.entries[current] = ZERO_ADDRESS; | |||
| } | |||
| self.entries[SENTINEL] = ZERO_ADDRESS; | |||
kopy-kat
commented
May 28, 2024
| @@ -86,7 +86,6 @@ library SentinelList4337Lib { | |||
| next = self.entries[next][account]; | |||
| self.entries[current][account] = ZERO_ADDRESS; | |||
| } | |||
| self.entries[SENTINEL][account] = ZERO_ADDRESS; | |||
kopy-kat
commented
May 28, 2024
| @@ -55,7 +55,6 @@ library LinkedBytes32Lib { | |||
| next = self.entries[next]; | |||
| self.entries[current] = ZERO; | |||
| } | |||
| self.entries[SENTINEL] = ZERO; | |||
kopy-kat
commented
May 28, 2024
| @@ -71,7 +70,7 @@ library LinkedBytes32Lib { | |||
| view | |||
| returns (bytes32[] memory array, bytes32 next) | |||
| { | |||
| if (start != SENTINEL && contains(self, start)) revert LinkedList_InvalidEntry(start); | |||
| if (start != SENTINEL && !contains(self, start)) revert LinkedList_InvalidEntry(start); | |||
| @@ -98,7 +97,7 @@ library LinkedBytes32Lib { | |||
| * incSENTINELrent page, nor will it be included in the next one if you pass it as a | |||
| * start. | |||
| */ | |||
| if (next != SENTINEL) { | |||
| if (next != SENTINEL && entryCount > 0) { | |||
There was a problem hiding this comment.
NOTE: fixes underflow bug previously fixed in other flavours of the lib
kopy-kat
commented
May 31, 2024
| @@ -39,6 +39,13 @@ library SentinelListLib { | |||
| self.entries[SENTINEL] = newEntry; | |||
| } | |||
|
|
|||
| function safePush(SentinelList storage self, address newEntry) internal { | |||
kopy-kat
commented
May 31, 2024
| @@ -61,6 +61,13 @@ library SentinelList4337Lib { | |||
| self.entries[SENTINEL][account] = newEntry; | |||
| } | |||
|
|
|||
| function safePush(SentinelList storage self, address account, address newEntry) internal { | |||
kopy-kat
commented
May 31, 2024
| @@ -39,6 +39,13 @@ library LinkedBytes32Lib { | |||
| self.entries[SENTINEL] = newEntry; | |||
| } | |||
|
|
|||
| function safePush(LinkedBytes32 storage self, bytes32 newEntry) internal { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.