Support more dates and more targets for comparison with jplephem #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly increases support for accuracy validation by comparing with the Python library jplephem.
Now, we have the following parameters:
de405
,de421
,de430t
,de440s
0
to10
This represents 730,520 combinations for which we compare the position (x, y, z) and velocity (vx, vy, vz) with
jplephem
.The Rake task has been redefined to take parameters so that we don't test everything at once, but only 18,263 lines by combinations of parameters. This was made so that validating accuracy could be run automatically on CI in a short amount of time (less than 3 minutes). Everything is declared in
validate_accuracy.yml
.The great news is that 4,383,120 values (3 for position, 3 for velocity, every day from 2000 to 2050, 10 targets and 4 kernels) match with
jplephem
within 2 centimeters or less.To keep them light-weight and performant, kernels have been reduced to excerpts using
jplephem
command-line tool:By the way, this is a function that I would like to implement into
Ephem
as well, one day.This reduces their weight by:
de405
from 65.4 MB to 5.6 MBde421
from 16.8 MB to 5.6 MBde430t
from 133.6 MB to 6.3 MBde440s
from 32.7 MB to 5.6 MBThe tested dates have been limited from 2000 to 2050 to keep execution time low and CSV files "short". We are entering 2025 to this is testing exactly 25 years ago and from now, which seems like a good compromise, but we could consider expanding coverage at some point.