Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curb the number of constructor arguments to Handler classes #15

Open
jirkadanek opened this issue Mar 10, 2018 · 1 comment
Open

Curb the number of constructor arguments to Handler classes #15

jirkadanek opened this issue Mar 10, 2018 · 1 comment
Assignees

Comments

@jirkadanek
Copy link

Currently, we have

  class ReceiverHandler < Handlers::SRCommonHandler

[...]

    def initialize(
      broker,
      log_msgs,
      count,
      process_reply_to,
      browse,
      sasl_mechs,
      exit_timer=nil
    )

[...]

The argument count is going to go up as we are adding more options, likely approaching 20 or even more. This should be rewritten somehow.

Possibly pass the options object in there directly.

@rkubis
Copy link
Contributor

rkubis commented Mar 13, 2018

Yes, this is in plan.

@rkubis rkubis changed the title Curb the number of constructor arguments to Hander classes Curb the number of constructor arguments to Handler classes Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants